Skip to content

HDDS-15200. Refactor TestReconOmMetaManagerUtils to ReconOmMetaManagerTestUtils#10480

Merged
adoroszlai merged 3 commits into
apache:masterfrom
arunsarin85:HDDS-15200
Jun 18, 2026
Merged

HDDS-15200. Refactor TestReconOmMetaManagerUtils to ReconOmMetaManagerTestUtils#10480
adoroszlai merged 3 commits into
apache:masterfrom
arunsarin85:HDDS-15200

Conversation

@arunsarin85

@arunsarin85 arunsarin85 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

  • Refactor TestReconOmMetaManagerUtils to ReconOmMetaManagerTestUtils

Please describe your PR in detail:

  • Rename TestReconOmMetaManagerUtils to ReconOmMetaManagerTestUtils
  • Make waitForEventBufferEmpty a static method
  • Make the utility class final with a private constructor
  • Remove instance fields from TestReconContainerEndpoint and TestReconWithOzoneManagerHA

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-15200

How was this patch tested?

  • Ran:
mvn -pl hadoop-ozone/integration-test-recon -am \
  -Dtest=TestReconContainerEndpoint,TestReconWithOzoneManagerHA \
  -DfailIfNoTests=false test
  • Build passed successfully

@adoroszlai adoroszlai added test code-cleanup Changes that aim to make code better, without changing functionality. labels Jun 10, 2026
adoroszlai
adoroszlai reviewed Jun 11, 2026
View reviewed changes

@adoroszlai adoroszlai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arunsarin85 for the patch. LGTM as is, but I would like to suggest minor tweaks.

Comment thread ...tion-test-recon/src/test/java/org/apache/hadoop/ozone/recon/ReconOmMetaManagerTestUtils.java Outdated
Comment thread ...tion-test-recon/src/test/java/org/apache/hadoop/ozone/recon/ReconOmMetaManagerTestUtils.java Outdated
Comment thread ...ation-test-recon/src/test/java/org/apache/hadoop/ozone/recon/TestReconContainerEndpoint.java Outdated
Comment thread ...tion-test-recon/src/test/java/org/apache/hadoop/ozone/recon/TestReconWithOzoneManagerHA.java Outdated
adoroszlai
adoroszlai approved these changes Jun 18, 2026
View reviewed changes

@adoroszlai adoroszlai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arunsarin85 for updating the patch.

@adoroszlai adoroszlai merged commit 2cece19 into apache:master Jun 18, 2026
31 of 32 checks passed
@arunsarin85 arunsarin85 deleted the HDDS-15200 branch June 18, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adoroszlai adoroszlai adoroszlai approved these changes

Assignees

No one assigned

Labels

code-cleanup Changes that aim to make code better, without changing functionality. test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arunsarin85 @adoroszlai